Add loading indicator to the test liveview #6023
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-richardson
force-pushed
the
liveview_loading_animation_134840
branch
from
dc75e93
to
2f09fda
Compare
okurz
requested changes
Oct 23, 2024
|
Martchus
reviewed
Oct 24, 2024
r-richardson
force-pushed
the
liveview_loading_animation_134840
branch
2 times, most recently
from
7cc1e96
to
c3b75de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6023 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 395 395
Lines 39382 39405 +23
=======================================
+ Hits 38982 39005 +23
Misses 400 400 ☔ View full report in Codecov by Sentry. |
okurz
requested changes
Oct 24, 2024
r-richardson
force-pushed
the
liveview_loading_animation_134840
branch
5 times, most recently
from
d7b26ba
to
35f7675
Compare
okurz
requested changes
Oct 24, 2024
okurz
reviewed
Oct 25, 2024
Martchus
reviewed
Oct 25, 2024
r-richardson
force-pushed
the
liveview_loading_animation_134840
branch
7 times, most recently
from
8f16459
to
8a59ae0
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
r-richardson
force-pushed
the
liveview_loading_animation_134840
branch
2 times, most recently
from
32b51a2
to
4f03389
Compare
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
r-richardson
force-pushed
the
liveview_loading_animation_134840
branch
from
4f03389
to
31caf0c
Compare
This PR adds a loading animation indicating that the liveview is being loaded. Currently only a empty box is displayed, visible in the webui before liveview content is received by the responsible canvas element. Test cases are also added to confirm the elements are displayed and hidden as expected. Related Issue: https://progress.opensuse.org/issues/134840
r-richardson
force-pushed
the
liveview_loading_animation_134840
branch
from
31caf0c
to
012ceaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a loading animation indicating that the liveview is being loaded. Currently only a empty box is displayed, visible in the webui before liveview content is received by the responsible canvas element.
Test cases are also added to confirm the elements are displayed and hidden as expected.
Related Issue: https://progress.opensuse.org/issues/134840