-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading indicator to the test liveview #6023
base: master
Are you sure you want to change the base?
Add loading indicator to the test liveview #6023
Conversation
dc75e93
to
2f09fda
Compare
|
7cc1e96
to
c3b75de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6023 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 395 395
Lines 39382 39405 +23
=======================================
+ Hits 38982 39005 +23
Misses 400 400 ☔ View full report in Codecov by Sentry. |
d7b26ba
to
35f7675
Compare
8f16459
to
8a59ae0
Compare
This pull request is now in conflicts. Could you fix it? 🙏 |
32b51a2
to
4f03389
Compare
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
4f03389
to
31caf0c
Compare
This PR adds a loading animation indicating that the liveview is being loaded. Currently only a empty box is displayed, visible in the webui before liveview content is received by the responsible canvas element. Test cases are also added to confirm the elements are displayed and hidden as expected. Related Issue: https://progress.opensuse.org/issues/134840
31caf0c
to
012ceaf
Compare
This PR adds a loading animation indicating that the liveview is being loaded. Currently only a empty box is displayed, visible in the webui before liveview content is received by the responsible canvas element.
Test cases are also added to confirm the elements are displayed and hidden as expected.
Related Issue: https://progress.opensuse.org/issues/134840